amazon-sumerian-hosts
amazon-sumerian-hosts copied to clipboard
Fix missing babylon types
[!Note] This is branched off of the branch for
- #183
See that PR first. For convenience, here's the diff between the branches, as the
Files changed
tab will not be useful.
Description
Babylone.js types were not visible within the Babylon host code.
Before:
After:
Related Issue #
- closes https://github.com/aws-samples/amazon-sumerian-hosts/issues/189
Reviewer Testing Instructions
Run npm install && npm run compile-ts
at the root of the repo. Then open packages/amazon-sumerian-hosts-babylon/src/Babylon.js/HostObject.js
and hover on Babylon APIs and you will see helpful tooltips showing types.
Submission Checklist
I confirm that I have...
- [x] removed hard-coded Cognito IDs
- [x] manually smoke-tested the BabylonJS integration tests
- [x] manually smoke-tested the BabylonJS demos
- [x] manually smoke-tested the Three.js integration tests
- [x] manually smoke-tested the Three.js demo
This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.