amazon-cognito-passwordless-auth icon indicating copy to clipboard operation
amazon-cognito-passwordless-auth copied to clipboard

Unable to use 1password for passkey

Open jplock opened this issue 1 year ago • 8 comments

Whenever I try to register a passkey saved in 1Password, this error message is shown in the UI:

Failed to activate face or touch unlock: credential.response is not an instance of AuthenticatorAttestationResponse

1Password is successfully saving the passkey though.

jplock avatar Feb 18 '24 02:02 jplock

Mmm not the first time we see 1password being idiosyncratic: https://github.com/aws-samples/amazon-cognito-passwordless-auth/issues/94

They inject themselves into the browser, but don't do so fully transparently. You should file an issue with them as well

ottokruse avatar Feb 18 '24 08:02 ottokruse

Strange, it works fine with Safari and 1Password, but not Firefox and 1Password

jplock avatar Feb 18 '24 16:02 jplock

Instead of doing the instanceof checks we could check the interface (duck typing):

https://github.com/aws-samples/amazon-cognito-passwordless-auth/blob/d7dda2898e5bfe227a4c5e5c4a46b1a07a4d83aa/client/fido2.ts#L87-L94

https://github.com/aws-samples/amazon-cognito-passwordless-auth/blob/d7dda2898e5bfe227a4c5e5c4a46b1a07a4d83aa/client/fido2.ts#L381-L388

ottokruse avatar Feb 19 '24 08:02 ottokruse

But as said, you should file this with 1Password as well

ottokruse avatar Feb 19 '24 08:02 ottokruse

I have no issues using 1Password for passkeys. Looks like localized issue. 1Password browser extension issues?

myevit avatar Feb 29 '24 23:02 myevit

You use Firefox too @myevit ?

ottokruse avatar Mar 01 '24 11:03 ottokruse

I use 3: Edge, Crome and Firefox. No issues with all of them with 1Password. there were some behaviour that browser bypassing 1Password passkey hook and go straight to system passkey UI, but so far I can tell, it is not an issue of your app.

myevit avatar Mar 01 '24 13:03 myevit

Update: Firefox start to give me credential.response is not an instance of AuthenticatorAssertionResponse error on filling out 1Password passkey. It might be happening long time ago, I do use Firefox only for developing. What's weird is that it's working on as dev on http://localhost:5173 but deployed to cloud. Edge has no issues. Windows Hello seems have no issues... Probably some 1Password extension bug.

myevit avatar Mar 13 '24 21:03 myevit