amazon-cognito-example-for-external-idp icon indicating copy to clipboard operation
amazon-cognito-example-for-external-idp copied to clipboard

Suggestion: add OIDC support

Open eranation opened this issue 3 years ago • 3 comments

The example currently supports SAML, and would be nice to also include an OIDC option.

This will need

  • update in the env.sh.template file to allow to choose this configuration
  • update readme
  • update cdk.ts to include an OIDC option (including auto discovery based on issuer etc)

eranation avatar May 25 '21 16:05 eranation

I have a working branch of that and would send a PR soon!

486 avatar Jun 15 '21 14:06 486

I've submitted a pull request for this. Could you please take a look @eranation ?

rajneeshr avatar Nov 02 '21 13:11 rajneeshr

I’m no longer with AWS, so I can’t approve but I’ll notify the new owners :)

On Tue, Nov 2, 2021 at 9:34 AM rajneran @.***> wrote:

I've submitted a pull request for this. Could you please take a look @eranation https://github.com/eranation ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aws-samples/amazon-cognito-example-for-external-idp/issues/47#issuecomment-957585542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF5JNPJVFXHK2KYJKGEJJDUJ7ZIFANCNFSM45PW2A6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

eranation avatar Nov 04 '21 16:11 eranation