amazon-bedrock-workshop icon indicating copy to clipboard operation
amazon-bedrock-workshop copied to clipboard

What is the difference between the 2 langchain_rag_retrieve_api files in module 2?

Open jicowan opened this issue 10 months ago • 3 comments

Aside from the model (Claude) the examples look nearly identical. Can we combine them?

jicowan avatar Apr 23 '24 20:04 jicowan

Instead of repeated examples with different models, why not show how you can use meta-data to narrow the scope of the query to the vector store, configure how many results are returned from the vector store, or how you can customize the system prompt when using Knowledge Bases. These new capabilities should be featured in the workshop.

jicowan avatar Apr 24 '24 22:04 jicowan

@jicowan I agree, we can consolidate and improve as you said.

@rsgrewal-aws I think you may have already been thinking in these lines

w601sxs avatar May 15 '24 19:05 w601sxs

The key difference is in ability to plug in functions calling and in second we demonstrate function calling with retriever. The Agents is able to invoke appropriate call based on the user query

From: Shreyas Subramanian @.> Reply-To: aws-samples/amazon-bedrock-workshop @.> Date: Wednesday, May 15, 2024 at 12:12 PM To: aws-samples/amazon-bedrock-workshop @.> Cc: "Grewal, Rupinder" @.>, Mention @.***> Subject: Re: [aws-samples/amazon-bedrock-workshop] What is the difference between the 2 langchain_rag_retrieve_api files in module 2? (Issue #238)

@jicowanhttps://github.com/jicowan I agree, we can consolidate and improve as you said.

@rsgrewal-awshttps://github.com/rsgrewal-aws I think you may have already been thinking in these lines

— Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/amazon-bedrock-workshop/issues/238#issuecomment-2113282218, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYMBZRWK2PSBXONUB3ZZ2RLZCOXRVAVCNFSM6AAAAABGVUCIWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJTGI4DEMRRHA. You are receiving this because you were mentioned.Message ID: @.***>

rsgrewal-aws avatar May 15 '24 20:05 rsgrewal-aws