rosbag-uploader-ros1 icon indicating copy to clipboard operation
rosbag-uploader-ros1 copied to clipboard

Add linting workflow that uses action-ros-lint

Open zmichaels11 opened this issue 4 years ago • 1 comments

Description of changes:

  • Add linting workflow that uses action-ros-lint. Note: this will use ament_lint on ROS 1 packages.
    • A ticket to improve ROS 1 support on action-ros-lint was opened: https://github.com/ros-tooling/action-ros-lint/issues/136
  • Add install_linters.sh which can be ran locally to install the required packages for ament_lint through PIP.
  • Add lint.sh which can be ran locally to run the ament linters on the packages.

install_linters.sh and lint.sh were tested on Ubuntu:Bionic

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Zachary Michaels [email protected]

zmichaels11 avatar Jul 07 '20 22:07 zmichaels11

Codecov Report

Merging #137 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          61       61           
  Lines        2579     2579           
=======================================
  Hits         2247     2247           
  Misses        332      332           
Flag Coverage Δ
#ROS_1 87.12% <ø> (ø)
#kinetic 88.13% <ø> (ø)
#melodic 88.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f351cf...1338f38. Read the comment docs.

codecov[bot] avatar Jul 07 '20 22:07 codecov[bot]