cdk-eks-blueprints icon indicating copy to clipboard operation
cdk-eks-blueprints copied to clipboard

feat: support argocd app of apps deployment

Open starchx opened this issue 2 years ago • 5 comments

Issue #, if available:

https://github.com/aws-quickstart/ssp-amazon-eks/issues/299

Description of changes:

This PR is based on @shapirov103 's branch and add App of Apps support on top.

A factory class is introduced to make it easy for our customers to enable or disable GitOps mode:

# Enable ArgoCD GitOps with each addon `Application` deployed by CDK:
ArgoGitOpsFactory.enableGitOps();

# Enable ArgoCD GitOps with all addons deployed via App of Apps:
ArgoGitOpsFactory.enableGitOpsAppOfApps();

Tested by destroying the cluster and recreating the cluster. All enabled addons were installed correctly by ArgoCD via App of Apps:

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Shout out to @shapirov103 's guidance in getting this PR created.

starchx avatar Feb 27 '22 07:02 starchx

Thanks for this @starchx! We will definitely need some documentation updates which explain how this functionality can be used.

kcoleman731 avatar Feb 28 '22 21:02 kcoleman731

@starchx echoing Kevin's comment: can you please attach documentation to the PR so that reviewers understand what the new functionality is?

shapirov103 avatar Mar 07 '22 23:03 shapirov103

@kcoleman731 @shapirov103 Thanks for reviewing the PR. I have just added the doc with example code of how to enable GitOps mode for deploying SSP AddOns. Apologize for the delays!

During the development, I am aiming to have both CDK and Terraform consuming the same AddOns repo, which is why I also created this PR to address some consistent issues.

Any feedback are much appreciated.

starchx avatar Mar 16 '22 06:03 starchx

@starchx thank you for making it mergeable. I was out last week, so slowly getting back. Will review this week. Thank you for the contribution! The launch is happening next week, we are in code freeze at the moment, but it will be a fast-follow.

shapirov103 avatar Apr 11 '22 19:04 shapirov103

Thanks again for the PR review @shapirov103 ☺️

All the suggestions are very good and making sense. I have updated the PR ready.

There is only one comment on this one: https://github.com/aws-quickstart/cdk-eks-blueprints/pull/300#discussion_r856837786

When you have time :slightly_smiling_face:

starchx avatar Apr 24 '22 01:04 starchx

@shapirov103 , I am closing this PR in favor of https://github.com/aws-quickstart/cdk-eks-blueprints/pull/588

starchx avatar Jan 31 '23 12:01 starchx