cdk-eks-blueprints icon indicating copy to clipboard operation
cdk-eks-blueprints copied to clipboard

added karpenter - k8s v1.32 compatibility

Open edgarfzo opened this issue 9 months ago • 2 comments

Feat:

  • added v 1.32 k8s compatibility to karpenter addon

Description of changes:

  • added an extra line to map minimumm version for k8s 1.32

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

edgarfzo avatar Feb 10 '25 13:02 edgarfzo

/do-e2e-tests

shapirov103 avatar Feb 12 '25 22:02 shapirov103

@edgarfzo the github action failed with

Error: lib/addons/karpenter/index.ts(19,28): error TS2551: Property 'V1_32' does not exist on type 'typeof KubernetesVersion'. Did you mean 'V1_20'?
make[1]: *** [Makefile:24: compile] Error 2
make[1]: Leaving directory '/home/runner/work/cdk-eks-blueprints/cdk-eks-blueprints'
make: *** [Makefile:21: build] Error 2
Error: Process completed with exit code 2.

I checked and in the latest CDK 2.178 there is no 1.32 support. Have you tested this change?

You are right, aws-cdk is about to release this change https://github.com/aws/aws-cdk/pulls?q=is%3Apr+1.32+is%3Aclosed

Let's wait to approve with the new aws cdk version

edgarfzo avatar Feb 14 '25 08:02 edgarfzo

Is this still being worked on? aws-cdk has support for 1.32 since v2.179.0

Note moving to version 1.1 or higher of karpenter will need further changes in the addon as support for the beta CRDs is removed in that version https://karpenter.sh/v1.3/upgrading/upgrade-guide/

paulchambers avatar Mar 25 '25 13:03 paulchambers

@edgarfzo Can you please update cdk version to 2.186.0 ?

vumdao avatar Mar 31 '25 11:03 vumdao

@edgarfzo Can you please update cdk version to 2.186.0 ?

Done

edgarfzo avatar Apr 01 '25 09:04 edgarfzo

Is this still being worked on? aws-cdk has support for 1.32 since v2.179.0

Note moving to version 1.1 or higher of karpenter will need further changes in the addon as support for the beta CRDs is removed in that version https://karpenter.sh/v1.3/upgrading/upgrade-guide/

Done

edgarfzo avatar Apr 01 '25 09:04 edgarfzo

/do-e2e-tests

shapirov103 avatar Apr 02 '25 16:04 shapirov103

@edgarfzo it fails basic build test. You can reproduce by running make build on your fork. The aws-cdk version has diverged, it is 2.1007.0 - not 2.186.

shapirov103 avatar Apr 03 '25 17:04 shapirov103

/do-e2e-tests

shapirov103 avatar May 02 '25 13:05 shapirov103