feat(event-handler): add base router class
Summary
Changes
Please provide a summary of what's being changed
Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed
Issue number: closes #3971
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
I've updated this PR with mkst of the changes that were in scope in #3971:
- Abstract
BaseRouterclass with HTTP method decorators ✅ - Basic route registration interface ✅
- Support for dynamic routes (:param syntax) ❌ dynamic routing has to be dealt with in the registry, which is implemented in the class that will extend
BaseRouter - Generic route() method for multiple HTTP methods ❌ route is an abstract method in the Python implementation so I followed that pattern
- Abstract resolve() method for concrete resolver implementation ✅
- Basic RouteHandler interface 💹
Note the two requirements not implemented, is there something I'm missing here that would let me ship them in this PR?
- Support for dynamic routes (:param syntax) ❌ dynamic routing has to be dealt with in the registry, which is implemented in the class that will extend
BaseRouter
You're right, this should've been in either #4139 or #4140
- Generic route() method for multiple HTTP methods ❌ route is an abstract class in the Python implementation so I followed that pattern
That's correct, nothing more to do here - it was phrased awkwardly.
Thanks!
Thank you both - as discussed offline, we'll merge the PR after tomorrow's release.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code