powertools-lambda-typescript icon indicating copy to clipboard operation
powertools-lambda-typescript copied to clipboard

feat!: version 2, the ESM update

Open dreamorosi opened this issue 6 months ago • 6 comments

Description of your changes

This PR includes all the changes for the next major version of Powertools for AWS Lambda (TypeScript).

The changes in the PR support the features described here, however the size of the PR is due to two factors:

  • this is a long running branch (6+ months)
  • to allow for ESM+CJS build we had to touch almost all files under packages/* and modify all imports and exports

The PR also includes changes to the docs & related code snippets.

Many of the changes in this branch have been reviewed in isolation when they were merged in the feat/v2 branch.

Related issues, RFCs

Issue number: #1714

Checklist

  • [x] My changes meet the tenets criteria
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my change is effective and works
  • [x] The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: YES

  • [x] I have documented the migration process
  • [ ] I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

dreamorosi avatar Feb 20 '24 21:02 dreamorosi

check PR title :D

heitorlessa avatar Feb 21 '24 08:02 heitorlessa

check PR title :D

Open to change the description, but the feat! part is intentional and it's what will trigger a major bump.

(sorry I mistakenly clicked the edit button rather than the quote reply one from mobile. Didn't mean to edit your comment!)

dreamorosi avatar Feb 21 '24 09:02 dreamorosi

Aha didn't know the !. By the power of grayskull I'll probably trust these 404 files are fine.

heitorlessa avatar Feb 21 '24 19:02 heitorlessa

I have just run the integration tests on this branch & they are green: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/7994389117

By the power of grayskull I'll probably trust these 404 files are fine.

giphy

dreamorosi avatar Feb 21 '24 19:02 dreamorosi

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
8.4% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] avatar Feb 27 '24 19:02 sonarcloud[bot]

Thanks a lot for the review @am29d, really appreciate you pouring time & effort to go through it.

I have addressed both your comments. Please feel free to start resolving any open conversion that you're aligned with & have no more questions on.

dreamorosi avatar Feb 27 '24 21:02 dreamorosi