powertools-lambda-python icon indicating copy to clipboard operation
powertools-lambda-python copied to clipboard

Maintenance: Review pipeline to update the aws-actions/configure-aws-credentials action

Open leandrodamascena opened this issue 2 years ago • 2 comments

Why is this needed?

The v3 major version of aws-actions/configure-aws-credentials has been released and is breaking our CI.

The role assumed in https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L182 is different from the role that should be outputted by this command https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L103.

Also, accountid is not masked by default and need to add special configuration to avoid problems with special characters (https://github.com/aws-actions/configure-aws-credentials#special-characters-in-aws_secret_access_key).

Which area does this relate to?

Automation

Solution

Investigate these problems before update this dependency.

Acknowledgment

leandrodamascena avatar Aug 29 '23 13:08 leandrodamascena

We merged the change and confirmed that the new version works: aws-powertools/powertools-lambda-typescript#1662

Another change in 3.x is that you now have to pass output-credentials for the credentials to be set as output of the step. We are not using that feature since we read from the environment, but you might have to put it since one of your examples reads from the steps.

dreamorosi avatar Aug 29 '23 17:08 dreamorosi

Hello @dreamorosi! Thank you so much for sharing this. I think our issue is with this output-credentials parameter. We'll investigate further, but this investigation of yours has shortened the path by miles.

:rocket:

leandrodamascena avatar Aug 29 '23 18:08 leandrodamascena

Adding triage back as I'm not sure where we landed with this. I suspect it's done?

heitorlessa avatar Jun 10 '24 08:06 heitorlessa

This was updated in V3 pipeline! Closing.

leandrodamascena avatar Aug 08 '24 19:08 leandrodamascena

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Aug 08 '24 19:08 github-actions[bot]