powertools-lambda-dotnet icon indicating copy to clipboard operation
powertools-lambda-dotnet copied to clipboard

chore: AOT support for Idempotency

Open hjgraca opened this issue 1 year ago • 2 comments

Please provide the issue number

Issue number: #212

Summary

Changes

Support for AOT in Idempotency and JMESPath.

Done:

  • Add JMESPathSerializationContext.cs and Serializer.
  • Add Idempotency IdempotencySerializationContext.cs and Serializer.
  • Update code to use both serializers

User experience

For serlializing client types inside Idempotency we now have a new method WithJsonSerializationContext. This method receives the client JsonSerializationContext

image

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • [ ] Migration process documented
  • [ ] Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

hjgraca avatar Sep 26 '24 18:09 hjgraca

Codecov Report

Attention: Patch coverage is 82.92683% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (6ee247c) to head (af59143). Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...ency/Internal/Serializers/IdempotencySerializer.cs 76.59% 7 Missing and 4 partials :warning:
...mbda.Powertools.Idempotency/IdempotentAttribute.cs 50.00% 0 Missing and 1 partial :warning:
...S.Lambda.Powertools.JMESPath/Values/DoubleValue.cs 0.00% 1 Missing :warning:
...bda.Powertools.JMESPath/Values/JsonElementValue.cs 90.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
+ Coverage    73.42%   73.43%   +0.01%     
===========================================
  Files          203      203              
  Lines         8173     8181       +8     
  Branches       877      878       +1     
===========================================
+ Hits          6001     6008       +7     
- Misses        1880     1881       +1     
  Partials       292      292              
Flag Coverage Δ
unittests 73.43% <82.92%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 27 '24 08:09 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Feb 04 '25 15:02 sonarqubecloud[bot]

E2E tests are green https://github.com/hjgraca/powertools-lambda-dotnet/actions/runs/13139110631

hjgraca avatar Feb 04 '25 16:02 hjgraca