aws-otel-lambda icon indicating copy to clipboard operation
aws-otel-lambda copied to clipboard

Run Integ tests for python 3.8 and 3.9 runtimes

Open vasireddy99 opened this issue 1 year ago • 6 comments

Description: Run Integ tests for python 3.8 and 3.9 runtimes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vasireddy99 avatar Jan 12 '24 16:01 vasireddy99

Why were 3.11 test removed?

bryan-aguilar avatar Jan 12 '24 17:01 bryan-aguilar

Why were 3.11 test removed?

python 3.11 runtime tests will be run as part of main build-workflow, the change here will make the test to run on default 3.11. its like we are running 3.[8,9,10] in this main-build-python workflow, and python 3.11 in main build-workflow

vasireddy99 avatar Jan 12 '24 17:01 vasireddy99

Is the purpose of main build to test again the latest versions? Why can't we have one workflow file to test against all versions? This may be follow up questions that are out of scope for this PR.

For this PR it would be good rename the file also.

bryan-aguilar avatar Jan 12 '24 18:01 bryan-aguilar

Is the purpose of main build to test again the latest versions? Why can't we have one workflow file to test against all versions? This may be follow up questions that are out of scope for this PR.

For this PR it would be good rename the file also.

I agree, we can have main build to test against latest versions, and the rest of the workflows on the other runtimes. if I remember correctly the include/exclude in the gh action matrix will be very very long list I guess to test in a single workflow and not effective, but I can take a look into it more if when we plan to grok these to see if it can be achieved. renamed the layer to main-build-python.

vasireddy99 avatar Jan 12 '24 18:01 vasireddy99

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Mar 17 '24 20:03 github-actions[bot]

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Jun 23 '24 20:06 github-actions[bot]