aws-otel-java-instrumentation
aws-otel-java-instrumentation copied to clipboard
Replace deprecated semantic attributes to fix the breaking change from OTEL 1.33
Issue
In the latest OTEL java SDK, it removes some semantic attributes Pulse uses to generate RemoteService and RemoteOperation. Once the SDK is released, our customers will see all their HTTP metrics becomes Unknown.
Upstream http PR: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/9968
Description of changes
Replace deprecated attributes with new attributes.
The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us.
https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1050 https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1070
Warning
Please DON'T merge this PR until OTEL 1.33 is integrated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
Attention: 102 lines
in your changes are missing coverage. Please review.
Comparison is base (
09e6487
) 85.71% compared to head (7b7b390
) 50.73%. Report is 185 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #636 +/- ##
=============================================
- Coverage 85.71% 50.73% -34.99%
- Complexity 19 264 +245
=============================================
Files 3 39 +36
Lines 49 1301 +1252
Branches 5 141 +136
=============================================
+ Hits 42 660 +618
- Misses 3 609 +606
- Partials 4 32 +28
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM! will click approve after the comments and build failures addressed. Thx
Thanks for the review. The build includes AppSignals contract testing, it will keep failing until 1.33 is released and integrated with ADOT.
The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us.
https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1050 https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1070
This PR is stale because it has been open 60 days with no activity.