terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Published 20 hours ago • verified publisher icon aws-ia

Added Datadog Addon

Open nayaksuraj opened this issue 2 years ago • 5 comments

What does this PR do?

In this pr, I have added datadog agent as a new addon to eks blueprint.

Motivation

I am moving cluster creations and addon management to terraform eks blueprint and found datadog is not there as addon. So I thought I should add.

More

  • [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ ] Yes, I have added a new example under examples to support my PR
  • [x] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [x] Yes, I have updated the docs for this feature
  • [x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • [ ] E2E Test successfully complete before merge?

Additional Notes

nayaksuraj avatar Sep 22 '22 10:09 nayaksuraj

duplicate of #882

bryantbiggs avatar Sep 24 '22 00:09 bryantbiggs

Hi @bryantbiggs one is helm based and the other is operator based.

nayaksuraj avatar Sep 27 '22 10:09 nayaksuraj

Hi @bryantbiggs since Datadog Operator is still public beta, I think it's better to have helm option. https://docs.datadoghq.com/containers/kubernetes/installation/?tab=operator#minimum-agent-and-cluster-agent-versions

sotoiwa avatar Dec 06 '22 05:12 sotoiwa

The Datadog Operator documentation itself recommends the Datadog Helm install method. https://github.com/DataDog/datadog-operator#datadog-operator-vs-helm-chart

One disadvantage of the Operator is that the Datadog agent is not deployed until a DatadogAgent resource is created. Terraform doesn't have a resource for DatadogAgent so a kubernetes_manifest resource would need to be used. kubernetes_manifest requires access to the k8s API during planning so it cannot be used without creating the cluster first. Using the helm method should be able to be used in the same TF run as cluster creation.

tsndqst avatar Dec 09 '22 21:12 tsndqst

@bryantbiggs any chance this can re-opened? I'd rather not re-implement this if this PR has working code.

tsndqst avatar Jan 06 '23 22:01 tsndqst

Thank you for the PR @nayaksuraj - since this is just simply a wrapper of the Datadog helm chart, I would suggest using the helm_release resource directly to deploy. At this time, we won't be adding this as a supported addon

bryantbiggs avatar Jan 21 '23 15:01 bryantbiggs