terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

[FEATURE] Add-ons to provide IAM role arn and name as outputs and IAM roles have easy to find prefix

Open andrewhibbert opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe

Would be good if each add on provides the details for the IRSA IAM role as outputs as it is difficult to find the roles as they are terraform-<uid>, perhaps a prefix would be good also so it is searchable in the UI

Describe the solution you'd like

As above

Describe alternatives you've considered

N/A

Additional context

N/A

andrewhibbert avatar Jul 29 '22 17:07 andrewhibbert

This is available today https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/irsa/outputs.tf

bryantbiggs avatar Aug 23 '22 14:08 bryantbiggs

It also needs to be in the outputs for the other modules though doesn't it - https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/outputs.tf

andrewhibbert avatar Aug 23 '22 15:08 andrewhibbert

apologies - this was not clear in the ticket with the lack of detail provided

bryantbiggs avatar Aug 23 '22 15:08 bryantbiggs

There were several problems reported too:

  • Outputs - need to be in https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/outputs.tf and potentially the addons themselves
  • IRSA role naming - Improved with https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/832. Though being able to change the role names is not exposed by the add-ons which would be useful

andrewhibbert avatar Aug 23 '22 15:08 andrewhibbert

There were several problems reported too:

Where were these reported?

bryantbiggs avatar Aug 23 '22 15:08 bryantbiggs

Here - https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/816#issue-1322497000.

I was finding it difficult to find the IAM roles before as they were terraform-

andrewhibbert avatar Aug 23 '22 15:08 andrewhibbert

you have roles named terraform-* today?

bryantbiggs avatar Aug 23 '22 15:08 bryantbiggs

Not with the latest versions as I've said here it is improved - https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/816#issuecomment-1224225999. You cannot override the role name though via the addons

andrewhibbert avatar Aug 23 '22 15:08 andrewhibbert

Hello @andrewhibbert this PR https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/908 is supposed to let consumers override the role name of IRSA though via the addons once it is merged.

florentio avatar Sep 10 '22 11:09 florentio

closed in #1136

bryantbiggs avatar Nov 21 '22 00:11 bryantbiggs