terraform-aws-eks-blueprints
terraform-aws-eks-blueprints copied to clipboard
aws-ia
add ec2:DescribeImages to karpenter IAM to support v0.14
Signed-off-by: Fernando Miguel [email protected]
What does this PR do?
Adds ec2:DescribeImages to karpenter IAM policy
Motivation
Karpenter v0.14 will require a new permission https://github.com/aws/karpenter/pull/2169/files#diff-7c5cd36388230ea106cff266bf0ab314b88b940b523b5acf523746f7baa496b7R117
More
- [ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
- [ ] Yes, I have added a new example under examples to support my PR
- [ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
- [ ] Yes, I have updated the docs for this feature
- [ ] Yes, I ran
pre-commit run -awith this PR
Note: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
- [ ] E2E Test successfully complete before merge?
Additional Notes
Lets wait for 0.14 to be released and update the karpenter example to demonstrate this new functionality and verify the permissions are correct
it's in the module, not the example. adding the extra policy today won't change it in anyway, but I'm fine with waiting until it is released, and we can bump the version too
A rc is out for testing https://github.com/aws/karpenter/releases/tag/v0.14.0-rc.0
Sadly I'm off on annual leave and unable to test anytime soon, prior to release.
This is now released https://github.com/aws/karpenter/releases/tag/v0.14.0
Would you mind updating the default addon version to point to this latest release, then we can merge this. We can also include https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/836 in this PR as well, thanks!
@bryantbiggs I'll pick this up tomorrow. Thanks for looking into it.
We can also include https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/836 in this PR as well, thanks! @bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.
We can also include #836 in this PR as well, thanks! @bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.
Its a one line change, I think its ok to add it here
We can also include #836 in this PR as well, thanks! @bryantbiggs i rather keep those things separate for whoever comes later reading the code can make sense of it.
Its a one line change, I think its ok to add it here
up to you :)