terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Setting enable_external_dns to true causes error

Open shawn-motley-dexcare opened this issue 3 years ago • 1 comments

Welcome to Amazon EKS Blueprints!

  • [X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version

4.4.0

What is your environment, configuration and the example used?

module "k8s_addons" { source = "github.com/aws-ia/terraform-aws-eks-blueprints//modules/kubernetes-addons?ref=v4.4.0"

eks_cluster_id = data.aws_eks_cluster.region_main.id

K8s

enable_external_dns = true }

What did you do and What did you see instead?

when setting the bool enable_external_dns = true

Error: Either name or zone_id must be set │ │ with module.k8s_addons.module.external_dns[0].data.aws_route53_zone.selected, │ on .terraform/modules/k8s_addons/modules/kubernetes-addons/external-dns/data.tf line 1, in data "aws_route53_zone" "selected": │ 1: data "aws_route53_zone" "selected" {

Additional Information

No response

shawn-motley-dexcare avatar Jul 11 '22 21:07 shawn-motley-dexcare

Hi @shawn-motley-dexcare, you will need to pass a value for eks_cluster_domain which is expected by the add-on as shown in this example.

askulkarni2 avatar Jul 12 '22 05:07 askulkarni2

closing with answer provided above

bryantbiggs avatar Aug 10 '22 14:08 bryantbiggs

They're is actually an issue here: the cluster_domain variable is used here: https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/external-dns/main.tf#L78

Although it's supposed to be deprecated as it says here: https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/external-dns/variables.tf#L20

ecoupal-believe avatar Apr 07 '23 10:04 ecoupal-believe

this has been resolved here https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/101

bryantbiggs avatar Apr 07 '23 11:04 bryantbiggs