terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Keep cert-manger installation outside of opentelemetry-operator module

Open gohmc opened this issue 3 years ago • 3 comments

The constraint to using cert-manager < 1.6.0 has been lifted as document here. While the version can be easily updated, but the cert-manager resource in the opentelemetry-operator module does not allow any customization and will conflict with existing cert-manager configured for the underlying cluster.

Suggest do not include cert-manager installation in the opentelemetry-operator module and let the addon or operator to use the cert-manager installed with enable_cert_manager. The code here can be updated to ensure existence of cert-manager:

count = var.enable_amazon_eks_adot || var.enable_opentelemetry_operator ? var.enable_cert_manager ? 1 : 0 : 0
depends_on = [module.cert_manager]
...

gohmc avatar Jul 10 '22 10:07 gohmc

@bonclay7 can you please confirm we can remove the cert-manager version v1.5.0 hard-coding now?

askulkarni2 avatar Jul 12 '22 05:07 askulkarni2

Yes, thanks for raising this. We will send an update shortly. As for reusing an existing cert-manager, we might take a different approach

bonclay7 avatar Jul 12 '22 05:07 bonclay7