terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Published 20 hours ago • verified publisher icon aws-ia

feat: Add kubernetes_timeouts variable.

Open kahirokunn opened this issue 2 years ago • 7 comments

What does this PR do?

add "timeouts" option for kubernetes resources.

Motivation

Due to a variety of factors, resource creation often does not complete within the default timeouts.

More

  • [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ ] Yes, I have added a new example under examples to support my PR
  • [ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [x] Yes, I have updated the docs for this feature
  • [x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • [ ] E2E Test successfully complete before merge?

Additional Notes

kahirokunn avatar Jul 06 '22 02:07 kahirokunn

@Zvikan How about this feature? If you like, I will add examples and resolve conflicts.

kahirokunn avatar Jul 16 '22 03:07 kahirokunn

@kahirokunn could you elaborate on this statement

Due to a variety of factors, resource creation often does not complete within the default timeouts.

What are the factors? How are you applying the resources (apply entire example with terraform apply or targetted applies with terraform apply -target=module.vpc && terraform apply -target=module.eks_blueprints && ...)?

bryantbiggs avatar Jul 16 '22 12:07 bryantbiggs

@bryantbiggs

I use Terraform Cloud. From my research, the Terraform Cloud runner is located in us-east-1. My AWS region is ap-northeast-1. The distance from us-east-1 to ap-northeast-1 is 6752 miles. Also, the Terraform Cloud runner is quite poor and network bandwidth is limited. For these reasons, it cannot be completed within the default timeout period.

The only way to reproduce the timeout is to create a kubernetes resource using Terraform Cloud on an EKS cluster in a region that is over 5000 miles away from us-east-1. I have tried over 1000 times and it always times out.

Is there any additional information you need? Thx.

kahirokunn avatar Jul 17 '22 03:07 kahirokunn

Hello 👀

kahirokunn avatar Jul 21 '22 08:07 kahirokunn

Ready for review. Thx 🙇

kahirokunn avatar Jul 22 '22 08:07 kahirokunn

Hello 👀 😢

kahirokunn avatar Jul 26 '22 07:07 kahirokunn

@vara-bonthu Hello! Could you please review it? 🙇

kahirokunn avatar Jul 30 '22 02:07 kahirokunn

@Zvikan Hello! Could you please review it? 🙇

kahirokunn avatar Aug 11 '22 07:08 kahirokunn

Hi there. Could I tell about that why this PR doesn't not review by anyone? I'm encountered to same problem. Please review it.

reoring avatar Aug 11 '22 07:08 reoring

hi @kahirokunn - we generally like to start with an issue and surface feedback there first and see if this is something that is affecting a small segment of users or a broad segment of users. right now this looks like a moderately large change due to a very niche condition. can we put this on hold now and start with an issue and see if others are experiencing similar issues before we move forward with implementations? thank you!

bryantbiggs avatar Aug 11 '22 13:08 bryantbiggs

@bryantbiggs im having the same issue., seems it is caused by slow VPN. I often need to run the same job 5-6 times. this also seems like a very small change. the repo just requires changing many places due to the repo not been very DRY

nahum-landa avatar Jan 18 '23 13:01 nahum-landa