terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

[QUESTION] aws_node_termination_handler and karpenter

Open FernandoMiguel opened this issue 2 years ago • 2 comments

Please describe your question here

How does aws_node_termination_handler addon and karpenter work? I see in the code at https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/793504a213662333a8e2e561e23fef2f650d82ff/modules/kubernetes-addons/main.tf#L122 that if ASG or karpenter are enabled , this addon can be made enabled. but while ASG do use , well...., ASG, karpenter nodes are individual instances.

Does it require us to manually tag those instances by adding this tag? https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/793504a213662333a8e2e561e23fef2f650d82ff/modules/kubernetes-addons/aws-node-termination-handler/main.tf#L24-L27

Provide link to the example related to the question

https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/793504a213662333a8e2e561e23fef2f650d82ff/modules/kubernetes-addons/main.tf#L122

More

  • [x] Yes, I have checked the repo for existing issues before raising this question

FernandoMiguel avatar Jun 20 '22 18:06 FernandoMiguel

I modified the NTH to match the resiliency section this blog entry, when karpenter is enabled. It should not need tagging.

mleklund avatar Jun 28 '22 03:06 mleklund

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jul 29 '22 00:07 github-actions[bot]

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Sep 04 '22 00:09 github-actions[bot]

Issue closed due to inactivity.

github-actions[bot] avatar Sep 14 '22 00:09 github-actions[bot]