terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

[FEATURE] Add some easy to see cautionary notes and helpful hints around KMS usage in the README & examples

Open spkane opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe

After helping out with this https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/485 and having had a similar issue early on here https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/414

It might be good to make sure that people using this module are aware of the basics of KMS and how they can protect themselves from unmanageable keys. It really is a pain when this happens, especially when you aren't really familiar with KMS and all of a sudden find yourself with a terraform stack that can't be easily destroyed and replaced.

Describe the solution you'd like

Add some very easy-to-discover documentation in the README and default examples for new users with a few warnings, and explanations of best practices, and bad outcomes.

spkane avatar May 01 '22 15:05 spkane

Thank you for creating this - I agree, theres a bit of work to do around KMS; possibly even externalizing it and instead showing example usage from an example/ rather than create within the root module.

bryantbiggs avatar May 02 '22 12:05 bryantbiggs

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jun 02 '22 00:06 github-actions[bot]

Will we see an any boolean option if we want to use kms or not ? I mean, something like: enable_kms = true/false in our tf file ?. @bryantbiggs

vrodriguezcl avatar Jun 27 '22 15:06 vrodriguezcl

This will be resolved in the upcoming v5 release

bryantbiggs avatar Jul 08 '22 21:07 bryantbiggs

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Aug 08 '22 00:08 github-actions[bot]

closed in #857

bryantbiggs avatar Aug 19 '22 17:08 bryantbiggs