terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

fix: Add `irsa_config` usage for all addons

Open igorbrites opened this issue 2 years ago • 0 comments

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Allow passing irsa_config inside the <addon>_helm_config.

Motivation

A way to pass that kubernetes_svc_image_pull_secrets to each addon from the kubernetes-addon module.

  • Resolves #1141

More

  • [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ ] Yes, I have added a new example under examples to support my PR
  • [ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [ ] Yes, I have updated the docs for this feature
  • [ ] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • [ ] E2E Test successfully complete before merge?

Additional Notes

I'm using this option on multiple EKS clusters, and it is very helpful altogether with imagepullsecret-patcher. I'll do the other tasks from the "More" section.

igorbrites avatar Dec 08 '22 18:12 igorbrites