terraform-aws-eks-blueprints
terraform-aws-eks-blueprints copied to clipboard
Cannot upgrade argocd
Description
The issue with upgrading argocd for missing the following:
app.kubernetes.io/managed-by: Helm
& app.kubernetes.io/instance: <RELEASE_NAME>

- [ ] ✋ I have searched the open/closed issues and my issue is not listed.
As described in this PR: https://github.com/helm/helm/pull/7649
⚠️ Note
Before you submit an issue, please perform the following first:
- Remove the local
.terraform
directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!):rm -rf .terraform/
- Re-initialize the project root to pull down modules:
terraform init
- Re-attempt your terraform plan or apply and check if the issue still persists
Versions
-
Module version [Required]: v4.16.0
-
Terraform version: v1.1.9
- Provider version(s):
Reproduction Code [Required]
Steps to reproduce the behavior:
Expected behaviour
Actual behaviour
Terminal Output Screenshot(s)
The same issue after annotating & label all applications & namespace under argocd
Additional context
I have just hit this issue too. I am using module version v4.17.0.
Any workarounds or fixes for this?
I have a workaround. I manually added the labels and annotations that Helm was complaining about, using kubectl
and a bit of shell:
kubectl get crds \
| awk '/argoproj/{print $1}' \
| xargs -n1 sh -c 'kubectl label crd $0 app.kubernetes.io/managed-by=Helm && kubectl annotate crd $0 meta.helm.sh/release-name=argo-cd meta.helm.sh/release-namespace=argocd'
After doing this the upgrade worked correctly via Terraform.
@domeales-paloit Thanks for sharing the solution. Successfully upgrade!
this looks to be an upstream issue that should be handled by ArgoCD, closing for now