terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

`irsa_config` is underused when using the `kubernetes-addons` module

Open igorbrites opened this issue 2 years ago • 0 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

I need to pass the same Docker Hub Credentials to all the namespaces created by the kubernetes-addons module to prevent that Docker Hub throttling error. Still, the root module does not pass the irsa_config variable (that has the kubernetes_svc_image_pull_secrets option) to each addon.

Describe the solution you would like

A way to pass that kubernetes_svc_image_pull_secrets to each addon from the kubernetes-addon module.

Describe alternatives you have considered

I can think in two ways:

  • Create variables like <addon>_irsa_config, just like the <addon>_helm_config ones, but we'll need to create all of them;
  • Allow passing irsa_config inside the <addon>_helm_config, though it's not a helm config.

Additional context

I created a branch with the second option but didn't create the PR yet because I want to know what you think first.

Edit: Created the Pull Request: https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1240

igorbrites avatar Nov 07 '22 20:11 igorbrites