terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Published 20 hours ago • verified publisher icon aws-ia

[ FEATURE ] Change installation method for argocd-application

Open armenmelkonyan90 opened this issue 3 years ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

To have the opportunity to install argocd-apps from the chart repository

Describe the solution you would like

The argocd submodule uses a custom helm-chart to install argocd-apps, this approach does not allow using the features of the official chart. I propose to change the submodule and give the opportunity to install the argocd-apps from the official or any other repository.

Additional context

I already have the solution. I'll create a pull request if this issue gets approved.

armenmelkonyan90 avatar Nov 01 '22 16:11 armenmelkonyan90

Which official helm chart are you referring to and what features are you trying to use?

askulkarni2 avatar Nov 10 '22 03:11 askulkarni2

There is an official helm chart for argo-apps (https://argoproj.github.io/argo-helm) that can be used as verified chart, also it includes not only argo-apps as provided in https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/argocd/argocd-application/helm/templates/application.yaml, but resources projects applicationsets & extensions. I propose feature to make repository of argocd-apps configurable as there can be custom argocd-app charts also but in default its repo would be argoproj's official chart argocd-apps.

armenmelkonyan90 avatar Nov 11 '22 11:11 armenmelkonyan90

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Dec 12 '22 00:12 github-actions[bot]

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Feb 21 '23 00:02 github-actions[bot]

Issue closed due to inactivity.

github-actions[bot] avatar Mar 03 '23 01:03 github-actions[bot]

is this still open?

hakmkoyan avatar Mar 04 '23 10:03 hakmkoyan