terraform-aws-eks-blueprints icon indicating copy to clipboard operation
terraform-aws-eks-blueprints copied to clipboard

Published 20 hours ago • verified publisher icon aws-ia

fix: Updating to make namespace creation optional

Open Pacobart opened this issue 2 years ago • 7 comments

What does this PR do?

Changes behavior of kube-prometheus-stack to conditionally create a namespace based on parameter set in helm_config. This will allow the chart to be deployed to a pre-existing namespace.

Motivation

  • Resolves #1056

More

  • [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ ] Yes, I have added a new example under examples to support my PR
  • [ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [ ] Yes, I have updated the docs for this feature
  • [x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • [ ] E2E Test successfully complete before merge?

Pacobart avatar Oct 14 '22 19:10 Pacobart

@bryantbiggs could moved be used here do handle pre-existing installations ?

FernandoMiguel avatar Oct 19 '22 11:10 FernandoMiguel

@bryantbiggs could moved be used here do handle pre-existing installations ?

yes, but we would need to increase the minimum supported version for Terraform to v1.1+ which is again a breaking change

bryantbiggs avatar Oct 19 '22 15:10 bryantbiggs

roger! thanks for clearing that up

FernandoMiguel avatar Oct 19 '22 15:10 FernandoMiguel

@bryantbiggs Is there a roadmap item to move to version 5 of the module with breaking changes?

Pacobart avatar Oct 19 '22 19:10 Pacobart

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Nov 19 '22 00:11 github-actions[bot]

This is still a needed feature. When is the next breaking change?

Pacobart avatar Nov 19 '22 01:11 Pacobart

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Dec 21 '22 00:12 github-actions[bot]

thank you for the PR - this will be resolved in the new addons module https://github.com/aws-ia/terraform-aws-eks-blueprints-addons

bryantbiggs avatar Mar 17 '23 19:03 bryantbiggs