terraform-aws-eks-blueprints-addons icon indicating copy to clipboard operation
terraform-aws-eks-blueprints-addons copied to clipboard

Update Velero addon to v5.x

Open bryantbiggs opened this issue 1 year ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

  • Update Velero addon to v4.x
  • Resolve https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/issues/307 in the changes implemented

Describe the solution you would like

  • Updated Velero to the latest major version. Since this is a major version change for the chart, there is most likely breaking changes to the values/schema used

Describe alternatives you have considered

Additional context

https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/f039cda83fc0902c398684387d95df9beb0143f6/main.tf#L3341

bryantbiggs avatar Oct 31 '23 23:10 bryantbiggs

@bryantbiggs velero latest chart is 5.1.2 not 4.0 To use 5.x here is the new structure of the helm values compatible with v5.x

This is already supported in gitops-bridge we need equivalent in addons v2.0 https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/argocd/bootstrap/control-plane/addons/aws/addons-aws-oss-velero-appset.yaml#L60-L85

            values: |
              configuration:
                backupStorageLocation:
                - name: default
                  provider: aws
                  prefix: {{metadata.annotations.velero_backup_s3_bucket_prefix}}
                  bucket: {{metadata.annotations.velero_backup_s3_bucket_name}}
                  config:
                    region: {{metadata.annotations.aws_region}}
                volumeSnapshotLocation:
                - name: default
                  provider: aws
                  config:
                    region: {{metadata.annotations.aws_region}}
              serviceAccount:
                server:
                  name: {{metadata.annotations.velero_service_account}}
                  annotations:
                    eks.amazonaws.com/role-arn: {{metadata.annotations.velero_iam_role_arn}}
              initContainers:
              - name: velero-plugin-for-aws
                image: velero/velero-plugin-for-aws:v1.7.1
                imagePullPolicy: IfNotPresent
                volumeMounts:
                  - mountPath: /target
                    name: plugins

csantanapr avatar Nov 01 '23 10:11 csantanapr

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jan 11 '24 00:01 github-actions[bot]

@bryantbiggs Hi, when is the v2.0 target date ?

Hokwang avatar Jan 16 '24 05:01 Hokwang