terraform-aws-control_tower_account_factory icon indicating copy to clipboard operation
terraform-aws-control_tower_account_factory copied to clipboard

Be consistent with the reality

Open Menahem1 opened this issue 2 years ago • 4 comments

Hello,

When i update some value on account request for existing account and it's failling there is a disconnect with the "reality"

For example let's say i change the name of the account or the username of SSO user, it will fail but the DynamoDB will not reflect the reality

is it possible to know the phase shift delta and also to go back to be in phase with reality ?

Hoping this is clear enough, I remain available if needed Thanks

Menahem1 avatar May 23 '22 15:05 Menahem1

Hey @Menahem1, can you clarify which table you're referring to?

Also just to recap, the enhancement you're looking for is to have AFT auto-update to reflect changes made external to AFT, is that correct?

balltrev avatar May 23 '22 22:05 balltrev

Hello @balltrev It's on aft-request table No, the enhancement is to know where there's delta with what AFT has not updated/failed (for ex. Account name or SSO Username) and with the reality (the account name has still that name, SSO Username is still with the old name, etc...) The problem is that for AFT it's "done" (the change) but this is not the case (ex. the account was not renamed) or alternative way a rollback in the DynamoDB table when it's failling to keep a consistent "state"

Menahem1 avatar May 24 '22 10:05 Menahem1

I think that runs the risk of the account request table not matching what's in the account request repository. Do you mind sharing your use case for reading directly from the account request table?

balltrev avatar May 27 '22 20:05 balltrev

This is mainly to keep edits via AFT in sync with what is actually being edited, without that i can edit 200 account's name and it will not be deployed in the reality (and of course for AFT everything is OK, tomorrow when it will be possible i will have to rollback the account request table to what is really existing to deploy that via AFT)

Also the account request table can serve as a referencial for account

Menahem1 avatar May 31 '22 13:05 Menahem1