terraform-aws-control_tower_account_factory icon indicating copy to clipboard operation
terraform-aws-control_tower_account_factory copied to clipboard

Published 20 hours ago • verified publisher icon aws-ia

account_tags change value not replaced on existing account

Open Menahem1 opened this issue 2 years ago • 1 comments

AFT Version: 1.3.7

Bug Description Editing one existing tag key on account_tags is not replaced we have 2 versions

To Reproduce Steps to reproduce the behavior:

  1. Go to one existing/provisionned account on AFT with account_tags and with existing value on the tag key, for example tag key "example"
  2. you want to edit the name of the key to "new_example"
  3. After the modification by the step function you will have on AWS Organizations on the tag account the 2 tags "example" and "new_example" the replacement was not made

Expected behavior replacement is done

Menahem1 avatar May 17 '22 09:05 Menahem1

Hey Ménahem, thanks for letting us know about this issue. I've created an item in our bug backlog; we'll have a look at this.

adam-daily avatar May 18 '22 17:05 adam-daily

We are hitting the same issue. Was wonder is there any progress on this? Or should we look into doing a custom check between AWS Org and the dynamodb with the account details.

pmmalinov01 avatar Dec 13 '22 13:12 pmmalinov01

Same issue. My problem is that removed tags are not deleted, only values are updated. Changed tags are just the old ones removed and the new ones created.

georgik-flutter avatar Dec 13 '22 13:12 georgik-flutter

At this time we have decided to not prioritize this change because changing this behavior to be PUT would negatively impact customers who put tags on their accounts outside of AFT. If additional information arises that would not compromise this behavior, we will revisit

hanafya avatar Dec 13 '22 19:12 hanafya