taskcat icon indicating copy to clipboard operation
taskcat copied to clipboard

fix(deps): upgrade cfn-lint range #838

Open dhutchison opened this issue 5 months ago • 6 comments

Overview

Widens the dependency range for cfn-lint to include the latest 1.x releases for #838.

Testing/Steps taken to ensure quality

Assuming existing test suite would pick up any incompatibilities with the newer versions.

This has been tested by installing pinned versions of cfn-lint for 0.80.1, 1.3.1 and the latest 1.16.0, and running pytest each time. An incompatibility was found with the first non-pre-release 1.x version (1.3.0), as it seemed to be missing the method to actually run checks (I'm assuming that was a regression).

Although I did have trouble running these locally initially - I think I'm just missing something and possibly the contributor guide needs updated to include steps to ensure the local environment is configured correctly and tests run locally.

Testing Instructions

How to test this PR Start after checking out this branch (bulleted)

  • Assuming existing unit test suite would pick up a dependency version incompatibility, and that these tests are ran automatically for PRs

dhutchison avatar Sep 25 '24 21:09 dhutchison