sagemaker-controller icon indicating copy to clipboard operation
sagemaker-controller copied to clipboard

tests: Ready condition rename for sagemaker-controller

Open gustavodiaz7722 opened this issue 2 months ago • 5 comments

This PR updates controller src and test files to the Ready condition:

  • Run code generation
  • Update test infra commit id
  • Replace ACK.ResourceSyncedReady
  • Replace assert_syncedassert_ready
  • Replace assert_not_syncedassert_not_ready

Generated by helper script.

No manual changes were made to the controller source; all changes were made via automated script.

gustavodiaz7722 avatar Sep 25 '25 06:09 gustavodiaz7722

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavodiaz7722 Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Sep 25 '25 06:09 ack-prow[bot]

/retest-required

gustavodiaz7722 avatar Sep 25 '25 22:09 gustavodiaz7722

/retest-required

gustavodiaz7722 avatar Sep 25 '25 23:09 gustavodiaz7722

/retest-required

gustavodiaz7722 avatar Sep 26 '25 00:09 gustavodiaz7722

@gustavodiaz7722: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-recommended-policy-test 5e7fffb7a21e5e58753a3bcd789091e192723f85 link true /test sagemaker-recommended-policy-test
sagemaker-metadata-file-test 5e7fffb7a21e5e58753a3bcd789091e192723f85 link true /test sagemaker-metadata-file-test
sagemaker-unit-test 5e7fffb7a21e5e58753a3bcd789091e192723f85 link true /test sagemaker-unit-test
sagemaker-release-test 5e7fffb7a21e5e58753a3bcd789091e192723f85 link true /test sagemaker-release-test
sagemaker-kind-e2e 5e7fffb7a21e5e58753a3bcd789091e192723f85 link true /test sagemaker-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Oct 30 '25 16:10 ack-prow[bot]