sagemaker-controller icon indicating copy to clipboard operation
sagemaker-controller copied to clipboard

Update to ACK runtime `v0.35.0`, code-generator `v0.35.0`

Open ack-bot opened this issue 1 year ago • 2 comments

Update to ACK runtime v0.35.0, code-generator v0.35.0



NOTE: This PR increments the release version of service controller from v1.2.11 to v1.2.12

Once this PR is merged, release v1.2.12 will be automatically created for sagemaker-controller

Please close this PR, if you do not want the new patch release for sagemaker-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker
Generating RBAC manifests for sagemaker
Running gofmt against generated code for sagemaker
Updating additional GitHub repository maintenance files
==== building sagemaker-controller release artifacts ====
Building release artifacts for sagemaker-v1.2.12
Generating common custom resource definitions
Generating custom resource definitions for sagemaker
Generating RBAC manifests for sagemaker

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ack-bot avatar Jul 19 '24 23:07 ack-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot Once this PR has been reviewed and has the lgtm label, please assign surajkota for approval by writing /assign @surajkota in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Jul 19 '24 23:07 ack-prow[bot]

/retest

a-hilaly avatar Jul 23 '24 21:07 a-hilaly

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-verify-attribution 6f5368fbf655f40d40c0477101f2d0f901292719 link true /test sagemaker-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Aug 30 '24 17:08 ack-prow[bot]