sagemaker-controller icon indicating copy to clipboard operation
sagemaker-controller copied to clipboard

Published 20 hours ago • verified publisher icon aws-controllers-k8s

Bugfix - handled panic due to difference in InputdataConfig size

Open ankurjha7 opened this issue 1 year ago • 7 comments

Description of changes:

The change handles panic due to runtime error : index out of range . The present code accesses b.ko.Spec.InputDataConfig[index] which can throw panic if size of b.ko.Spec.InputDataConfig is smaller than a.ko.Spec.InputDataConfig

The solution checks for this condition and sets the a.ko.Spec.InputDataConfig[index].RecordWrapperType to default type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ankurjha7 avatar May 22 '24 15:05 ankurjha7

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankurjha7 Once this PR has been reviewed and has the lgtm label, please assign surajkota for approval by writing /assign @surajkota in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar May 22 '24 15:05 ack-prow[bot]

Hi @ankurjha7. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar May 22 '24 15:05 ack-prow[bot]

cc @aws-controllers-k8s/sagemaker-maintainer

a-hilaly avatar Jun 04 '24 07:06 a-hilaly

cc @ryansteakley

a-hilaly avatar Jun 04 '24 07:06 a-hilaly

/assign @a-hilaly

ankurjha7 avatar Aug 06 '24 08:08 ankurjha7

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Feb 02 '25 12:02 ack-bot

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Apr 03 '25 13:04 ack-bot

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Jun 02 '25 14:06 ack-bot

@ack-bot: Closed this PR.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Jun 02 '25 14:06 ack-prow[bot]