sagemaker-controller icon indicating copy to clipboard operation
sagemaker-controller copied to clipboard

Feature - Add/Modify/Delete tags for model resource

Open rkurduka opened this issue 11 months ago • 5 comments

Issue 1732, if available:

Description of changes: Currently tags modification is not supported for model resource . Hence added require changes to support tags modification.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rkurduka avatar Mar 01 '24 10:03 rkurduka

/retest

a-hilaly avatar Mar 02 '24 23:03 a-hilaly

/hold

a-hilaly avatar Mar 02 '24 23:03 a-hilaly

@rkurduka we have plans to start generating Tag handlers for all the ACK controllers. But nothing stops us from implement some manually if there is urgent need for them :) I left few comments in-line

@a-hilaly - thanks for update . Yes there was customer ask for this . Issue 1732 has details

rkurduka avatar Mar 05 '24 06:03 rkurduka

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka Once this PR has been reviewed and has the lgtm label, please ask for approval from ryansteakley by writing /assign @ryansteakley in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Mar 05 '24 06:03 ack-prow[bot]

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-unit-test 99037c217949d2cf94caa2c273d4a1d10c73a9e9 link true /test sagemaker-unit-test
sagemaker-kind-e2e 99037c217949d2cf94caa2c273d4a1d10c73a9e9 link true /test sagemaker-kind-e2e
sagemaker-verify-attribution 99037c217949d2cf94caa2c273d4a1d10c73a9e9 link true /test sagemaker-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Aug 30 '24 17:08 ack-prow[bot]