s3-controller icon indicating copy to clipboard operation
s3-controller copied to clipboard

feat(kmsMasterKeyRef): allow Bucket encryption with KMS key reference

Open starlightromero opened this issue 7 months ago • 3 comments

Solves aws-controllers-k8s/community#1649

starlightromero avatar Apr 27 '25 16:04 starlightromero

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: starlightromero Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Apr 27 '25 16:04 ack-prow[bot]

Hi @starlightromero. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Apr 27 '25 16:04 ack-prow[bot]

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Oct 24 '25 16:10 ack-bot