aws-controllers-k8s
Ignore fields added in the new SDK version
Issue #, if available:
Description of changes:
https://github.com/aws-controllers-k8s/elasticache-controller/pull/137 added support for the CacheCluster resource but left ignoring newly added fields for later. This changelist adds unsupported fields to the list of fields to ignore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi @cPu1. Thanks for your PR.
I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ack-prow[bot] avatar](https://avatars.githubusercontent.com/in/260409?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cPu1 looks like the controller isn't compiling, can you PTAL?
Sure, please give me some time. I am juggling between a few tasks at the moment.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cPu1
Once this PR has been reviewed and has the lgtm label, please ask for approval from a-hilaly by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch
@cPu1 I tried to disable a very flaky tests but looks like some others are failing can you please take a look at this? It's blocking the 0.38.0 runtime patch
@a-hilaly, sure, I'll look into it. That failing test should be unaffected by the changes introduced in this PR, but I'll see how best to resolve it.
@cPu1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| elasticache-verify-attribution | 44005e601d339034499a35b3584dc4b906e88164 | link | false | /test elasticache-verify-attribution |
| elasticache-kind-e2e | 44005e601d339034499a35b3584dc4b906e88164 | link | true | /test elasticache-kind-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
@rushmash91: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.