eks-controller icon indicating copy to clipboard operation
eks-controller copied to clipboard

fix: set proper desiredSize when increasing minSize

Open jose-ledesma opened this issue 4 months ago • 2 comments

Description of changes:

When desiredSize is managed by external autoscaling, the ACK EKS controller will not increase minSize if it exceeds desiredSize, instead reporting the following error:

  Conditions:
    Last Transition Time:  2025-09-02T12:59:44Z
    Status:                True
    Type:                  ACK.ResourceSynced
    Message:               InvalidParameterException: Minimum capacity 2 can't be greater than desired size 1
    Status:                True
    Type:                  ACK.Terminal

This PR ensures that when minSize exceeds desiredSize, the desiredSize will be automatically adjusted to match minSize, preventing the operation from failing and ensuring successful resource updating.

jose-ledesma avatar Sep 02 '25 13:09 jose-ledesma

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jose-ledesma Once this PR has been reviewed and has the lgtm label, please assign knottnt for approval by writing /assign @knottnt in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Sep 02 '25 13:09 ack-prow[bot]

Hi @jose-ledesma. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Sep 02 '25 13:09 ack-prow[bot]