eks-controller icon indicating copy to clipboard operation
eks-controller copied to clipboard

Remove deprecated aws-go-sdk-v1

Open taraspos opened this issue 4 months ago • 4 comments

Issue #, if available: https://github.com/aws-controllers-k8s/runtime/pull/169

Description of changes:

Go SDK V1 is deprecated now^1, this PR removes any direct references to it.

There are still indirect ones, because of dependency on ec2-controller:

$ go mod why -m github.com/aws/aws-sdk-go
# github.com/aws/aws-sdk-go
github.com/aws-controllers-k8s/eks-controller/cmd/controller
github.com/aws-controllers-k8s/ec2-controller/apis/v1alpha1
github.com/aws/aws-sdk-go/aws

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

taraspos avatar Aug 14 '25 11:08 taraspos

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taraspos Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Aug 14 '25 11:08 ack-prow[bot]

Hi @taraspos. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Aug 14 '25 11:08 ack-prow[bot]

/ok-to-test

taraspos avatar Aug 14 '25 11:08 taraspos

@taraspos: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Aug 14 '25 12:08 ack-prow[bot]