eks-controller icon indicating copy to clipboard operation
eks-controller copied to clipboard

feat(addon): Add support for PodIdentityAssociations

Open a-hilaly opened this issue 1 year ago • 2 comments

This commit introduces support for PodIdentityAssociations in Addons CRD, enhancing the controller's capabilities to manage PIAs directly through the Addon resources.

Key changes:

  • Bump the sdk to v1.54.1 to bring the latest API schema changes
  • Introduce PodIdentityAssociations to the addons spec
  • Add custom logic for:
    • extracting ServiceAccounts/RoleARNs from a given PIA association ID
    • properly comparing two arrays of PIAs
  • Enhanced Addon status checks and requeue logic to ensure proper synchronization
  • Add some unit tests and e2e tests for Addon.PIAs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

a-hilaly avatar Jul 11 '24 06:07 a-hilaly

/lgtm

michaelhtm avatar Oct 02 '24 18:10 michaelhtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Oct 02 '24 18:10 ack-prow[bot]

/retest

a-hilaly avatar Oct 02 '24 19:10 a-hilaly

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-verify-attribution 4acca6dfa7af59a2612be05d2e5d2cec175fb107 link false /test eks-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Oct 02 '24 19:10 ack-prow[bot]