Prevent incorrect change in routeTable CR spec after adding route addition having vpcEndpointID
Issue #1935
Description of changes: This fix accomodates an aws api bug so as to prevent routeTable CR spec from changing. Details explained in the issue description.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi @nnbu. Thanks for your PR.
I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/test all
@a-hilaly This was approved but hold was never removed. So, this is still not merged.
@nnbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ec2-verify-attribution | 50e122d34193a2c492762a6fd2bd0dff2340cb48 | link | false | /test ec2-verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-hilaly, nnbu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [a-hilaly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment