ec2-controller icon indicating copy to clipboard operation
ec2-controller copied to clipboard

networkAcl update fails if ruleAction field has camelcase Allow/Deny

Open nnbu opened this issue 2 years ago • 4 comments

Issue #1966

Description of changes: RCA and steps to reproduce are mentioned in the issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nnbu avatar Dec 14 '23 23:12 nnbu

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Dec 14 '23 23:12 ack-prow[bot]

/test all

a-hilaly avatar Feb 18 '24 06:02 a-hilaly

/test all

a-hilaly avatar Jun 19 '24 16:06 a-hilaly

@nnbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 503577a9be4a384b35c386f885fa020cc8b85342 link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Sep 19 '24 19:09 ack-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, nnbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Sep 19 '24 23:09 ack-prow[bot]