ec2-controller icon indicating copy to clipboard operation
ec2-controller copied to clipboard

Ec2 template with version

Open rkurduka opened this issue 2 years ago • 5 comments

Issue #, if available: 1841 Description of changes: New resource added "launchtemplateversion"

  1. Create new launchtemplateversion.
  2. Create new launchtemplateversion based on given sourceversion
  3. Delete launchtemplateversion

There is separate PR for "launchtemplate" already open and in progress #151

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rkurduka avatar Oct 19 '23 17:10 rkurduka

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka Once this PR has been reviewed and has the lgtm label, please assign jljaco for approval by writing /assign @jljaco in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Oct 19 '23 17:10 ack-prow[bot]

Hi @rkurduka. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Oct 19 '23 17:10 ack-prow[bot]

/ok-to-test

a-hilaly avatar Oct 27 '23 10:10 a-hilaly

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Jul 09 '24 08:07 ack-bot

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-recommended-policy-test 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-recommended-policy-test
ec2-metadata-file-test 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-metadata-file-test
ec2-kind-e2e 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-kind-e2e
ec2-release-test 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-release-test
ec2-unit-test 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-unit-test
ec2-verify-attribution 7838bee35317c842c0cb9ed0e125ede6a07f249e link true /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Aug 30 '24 18:08 ack-prow[bot]