ec2-controller icon indicating copy to clipboard operation
ec2-controller copied to clipboard

Published 20 hours ago • verified publisher icon aws-controllers-k8s

Ec2: Network ACL CR should support deletion when subnet association is present

Open nnbu opened this issue 1 year ago • 7 comments

Issue #, if available:

Description of changes: Currently, when network acl cr has subnet association configured, we can not delete the cr. subnet association needs to be removed first and then cr can be deleted. This PR addresses this issue. When network acl CR is being deleted, the new change deletes subnet association from aws first and then deletes network acl from aws. This allows CR deletion to happen without any problem.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nnbu avatar Oct 17 '23 16:10 nnbu

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Oct 17 '23 16:10 ack-prow[bot]

@a-hilaly Please review when you get a chance

nnbu avatar Oct 20 '23 16:10 nnbu

/ok-to-test

a-hilaly avatar Oct 24 '23 21:10 a-hilaly

I have addressed the comments. Please review when you get a chance. @a-hilaly

nnbu avatar Nov 01 '23 15:11 nnbu

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Apr 29 '24 19:04 ack-bot

/test all

a-hilaly avatar Jun 04 '24 07:06 a-hilaly

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Aug 13 '24 20:08 ack-bot

@nnbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 1c4ba67f3d14086ca3607a0e15edd1b63d91bc0d link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Sep 17 '24 19:09 ack-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, nnbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Sep 17 '24 21:09 ack-prow[bot]