aws-controllers-k8s
new resource ec2launch template and test caes
Issue #, if available: 1841
Description of changes:
New resource added - LaunchTemplate Test cases added.
Features:
- Create new EC2 launch template
- Delete existing EC2 launch template
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi @rkurduka. Thanks for your PR.
I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ack-prow[bot] avatar](https://avatars.githubusercontent.com/in/260409?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rkurduka
Once this PR has been reviewed and has the lgtm label, please assign jljaco for approval by writing /assign @jljaco in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rkurduka
Once this PR has been reviewed and has the lgtm label, please assign jljaco for approval by writing /assign @jljaco in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
Is there anything particular blocking this PR from being merged, other than having a merge conflict after having been stale for 6m?
@rkurduka ok if i cherry pick your changes to keep working on the changes you started so we can get this functionality in?
@rkurduka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ec2-verify-attribution | 04807c596fb91e608c62fd97c8ee402d55c49b81 | link | true | /test ec2-verify-attribution |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
I'm afraid other projects fit our use case better, so haven't looked further into it.
@kejne no worries :) may I ask what projects are you using to workaround this and manage launch templates?
It wasn't really just about Launch Templates, but more of the whole. For example, since we will be leveraging multiple cloud providers we are leaning more towards Crossplane atm.