ec2-controller icon indicating copy to clipboard operation
ec2-controller copied to clipboard

added launch template and launch templateversion as resource

Open rkurduka opened this issue 2 years ago • 7 comments

Issue #, if available: #1841

Description of changes:

EC2 resource added - Launch template and LaunchTemplateversion

Functionalities:

  1. Create ec2 launch template
  2. set default version for launch template
  3. Create new versions of launch template ( separate resource launchtemplateversions)
  4. Delete launch template versions
  5. Delete launch template and its versions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rkurduka avatar Aug 10 '23 08:08 rkurduka

Hi @rkurduka. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Aug 10 '23 08:08 ack-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka Once this PR has been reviewed and has the lgtm label, please assign vijtrip2 for approval by writing /assign @vijtrip2 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar Aug 10 '23 08:08 ack-prow[bot]

Any update or changes require on this , please let me know

rkurduka avatar Aug 21 '23 15:08 rkurduka

Please let me know if anything else is require here ,

rkurduka avatar Aug 31 '23 11:08 rkurduka

raised separate PR - 151 for launch template only - will raise separate one for launch template version

rkurduka avatar Oct 04 '23 10:10 rkurduka

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Apr 01 '24 12:04 ack-bot

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-release-test d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-release-test
ec2-metadata-file-test d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-metadata-file-test
ec2-unit-test d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-unit-test
ec2-kind-e2e d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-kind-e2e
ec2-recommended-policy-test d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-recommended-policy-test
ec2-verify-attribution d112707c8bf9d96cee603d8b0057358d1acbd222 link true /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Aug 30 '24 18:08 ack-prow[bot]