community
community copied to clipboard
aws-controllers-k8s
Allow configuration of volumes and environment variables in the controller charts
Is your feature request related to a problem? In particular, I am interested in being able to add the necessary configuration options to support IRSA without using the identity webhook.
Describe the solution you'd like In simplest terms, it is a matter of allowing volumes, volumeMounts, and env to be set through helm charts. These are very common chart configuration options for other purposes as well.
Sure. I could also see annotations, affinities, tolerations and node selectors being useful.
@olemarkus what do you envision the Deployment for an ACK controller to need additional volume mounts for? I can definitely see the need for additional envVars, though.
As mentioned, this is needed for IRSA. See https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#service-account-token-volume-projection
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
