community icon indicating copy to clipboard operation
community copied to clipboard

Remove canary tests from applicationautoscaling-controller

Open jaypipes opened this issue 3 years ago • 7 comments

The canary tests that were added to the applicationautoscaling-controller repository are specific to SageMaker and not the applicationautoscaling-controller codebase. They should be removed.

jaypipes avatar Jul 08 '21 18:07 jaypipes

application autoscaling needs a resource that can be registered for scaling. e2e tests use sagemaker endpoint as a scalable resource to test scalable target and scaling policy in this test. Similarly, there are other tests that use dynamodb as scalable resource

The PR that is originally listed in this issue is related to some helper scripts/configurations which help run e2e tests on released helm charts on an EKS cluster (i.e. canary)

can you provide more details on why these tests or scripts should be removed?

surajkota avatar Aug 03 '21 01:08 surajkota

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Nov 17 '21 17:11 ack-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Dec 17 '21 17:12 ack-bot

/remove-lifecycle stale

a-hilaly avatar Dec 20 '21 11:12 a-hilaly

/remove-lifecycle rotten

a-hilaly avatar Dec 20 '21 11:12 a-hilaly

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Mar 20 '22 11:03 ack-bot

/lifecycle frozen

vijtrip2 avatar Mar 21 '22 23:03 vijtrip2