community icon indicating copy to clipboard operation
community copied to clipboard
verified publisher icon aws-controllers-k8s

Multiple adopted resources can create duplicate resources

Open RedbackThomson opened this issue 4 years ago • 4 comments

Describe the bug Two uniquely named AdoptedResource types referencing the same nameOrID or ARN can independently create two new K8s ACK resources that reference the same AWS resource. This could result in multiple ACK resources fighting over source-of-truth if either of them changes the specification.

Steps to reproduce

  1. Adopt an S3 bucket with one AdoptedResource
  2. Adopt the same S3 bucket with another AdoptedResource of a different name
  3. Check to see that both buckets appear to be managed by ACK

Expected outcome Some sort of warning should be placed on the second adopted resource that clearly states the target AWS resource is already being managed. The second adopted resource should not create any additional resources.

Environment

  • Kubernetes version
  • Using EKS (yes/no), if so version?
  • AWS service targeted (S3, RDS, etc.)

RedbackThomson avatar Jun 23 '21 18:06 RedbackThomson

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Sep 21 '21 23:09 ack-bot

/remove-lifecycle stale

vijtrip2 avatar Sep 22 '21 18:09 vijtrip2

/lifecycle frozen

vijtrip2 avatar Sep 22 '21 18:09 vijtrip2

can someone pick this up and verify if we see the same issue via adoption through annotations?

jlbutler avatar Jun 05 '25 21:06 jlbutler

I'm unsure of a gitops use case with same resource being adopted twice.. @michaelhtm you think we'd need to look into this adoption by annotation? is this something we should be concerned about?

cc @knottnt @a-hilaly

rushmash91 avatar Jul 28 '25 19:07 rushmash91

We haven't seen any customer created issues for this. If we do, it would still be relevant for adoption by annotation as well

michaelhtm avatar Jul 28 '25 22:07 michaelhtm

I see we can close this then. /close

rushmash91 avatar Jul 28 '25 22:07 rushmash91

@rushmash91: Closing this issue.

In response to this:

I see we can close this then. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Jul 28 '25 22:07 ack-prow[bot]