community icon indicating copy to clipboard operation
community copied to clipboard

[code-gen] Scalar fields produce inconsistent capitalization in error messages between runs of the code-generator

Open knottnt opened this issue 7 months ago • 2 comments

Describe the bug The error message produced for scalar fields in the boundary check for floats and ints has inconsistent capitalization of the field name between runs of the code-gen. This results in superfluous changes when making unrelated changes to controllers.

Steps to reproduce

  1. Pull the latest changes for the ecs-controller repo
  2. In code-generation re-run make build-controller
  3. See that some float/int field names will have changed in error messages for the boundary check. Note, the individual fields that have changed aren't consistent.

example field name change.

return nil, fmt.Errorf("error: field iops is of type int32") -> return nil, fmt.Errorf("error: field Iops is of type int32")

Expected outcome No changes besides ack-generate-meta.yaml are made to the controller.

Environment

  • Kubernetes version: N/A
  • Using EKS (yes/no), if so version? N/A
  • AWS service targeted (S3, RDS, etc.) ECS, but this affects many controllers.

knottnt avatar May 28 '25 18:05 knottnt

Hello @knottnt 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

github-actions[bot] avatar May 28 '25 18:05 github-actions[bot]

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Nov 24 '25 23:11 ack-bot