CloudFront Distribution CRD's customOriginConfig:httpSPort has incorrect capitalization

[knottnt]

Describe the issue The CRD for CloudFront Distribution has an incorrect capitalization for the distributionConfig:origins:items:customOriginConfig:httpSPort spec field. httpSPort should be httpsPort. This doesn't create any functional issues, but may be worth fixing if/when a new major version of the CloudFront ACK controller is released.

Expected outcome distributionConfig:origins:items:customOriginConfig:httpSPort -> distributionConfig:origins:items:customOriginConfig:httpsPort

[github-actions[bot]]

Hello @knottnt 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[sga80]

@knottnt , I can take a look at this. Do we need to do new API version and write a conversion from old API to new?

[knottnt]

@sga80: Since this is a breaking change to the CRD I think this would require new version and a hook to convert existing CRDs to the new version would be helpful. That said, it might be worth holding off on fixing this until an other feature or change that affects functionality requires a major version change. Having the mis-capitalization is annoying, but doesn't break any functionality.

cc: @a-hilaly

[knottnt]

For more context we noticed this issue when implementing CloudFront's VPC Origin resource which also has an httpsPort field. To avoid propagating the mis-capitalization we fixed the root cause in the pkg repo, but forced the existing distributionConfig:origins:items:customOriginConfig:httpSPort field to httpSPort here in order to avoid introducing a breaking change to the CloudFront controller.

[sga80]

@knottnt , makes sense. I will close my PR and can pick it up when there is a requirement to create a new API version

[ack-bot]

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale